[v24.1.x] [CORE-5632] cluster: Reset cloud storage metric in the cluster::partition::remove_persistent_state
#21620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in the partition::remove_persistent state. The probe has access to the global state so it's not safe to keep it after the partition is stopped and `remove_persistent_state` method is invoked. In cases when the partition is recreated with different revision id the 'double metric registration' error could be triggered. The double metric registration exception prevents normal parittion removal and subsequent partition creation may trigger assertion. (cherry picked from commit 51af1b4)
|
@Lazin is this blocked on anything? |
piyushredpanda
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #21581