[CORE-5632] cluster: Reset cloud storage metric in the cluster::partition::remove_persistent_state
#21581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrwng
previously approved these changes
Jul 23, 2024
src/v/cluster/partition.cc
Outdated
| @@ -902,6 +902,7 @@ partition::get_cloud_term_last_offset(model::term_id term) const { | |||
| } | |||
|
|
|||
| ss::future<> partition::remove_persistent_state() { | |||
| _cloud_storage_probe = nullptr; | |||
There was a problem hiding this comment.
Wondering if this belongs in partition::stop()? Also wondering if we should be calling _cloud_storage_probe->clear_metrics(), as we do with the partition::_probe?
There was a problem hiding this comment.
added clear metrics method
Lazin
changed the title
cluster::partition::remove_persistent_statecluster::partition::remove_persistent_state
... in the partition::remove_persistent state. The probe has access to the global state so it's not safe to keep it after the partition is stopped and `remove_persistent_state` method is invoked. In cases when the partition is recreated with different revision id the 'double metric registration' error could be triggered. The double metric registration exception prevents normal parittion removal and subsequent partition creation may trigger assertion.
Lazin
force-pushed
the
fix/node-decom-same-ntp
branch
from
52fb95a
to
51af1b4
Compare
abhijat
approved these changes
Jul 24, 2024
|
/backport v24.2.x |
|
/backport v24.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The probe has access to the global state so it's not safe to keep it after the partition is stopped and
remove_persistent_statemethod is invoked. In cases when the partition is recreated with different revision id the 'double metric registration' error could be triggered.When the exception is triggered the
partition_manageris not able to remove the partition from the collection and subsequent re-creation of the partition with different ntp produces assertion because ntp already exists.Backports Required
Release Notes