Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.1.x] archival: keep locks until outcome is known #21521

Merged
merged 2 commits into from
Jul 21, 2024
Merged

[v24.1.x] archival: keep locks until outcome is known #21521

merged 2 commits into from
Jul 21, 2024

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #21348
Fixes: #21520,

@nvartolomei @vbotbuildovich
archival/tests: fix use-after-heap in case of failure
b1d330e 
We never saw it as the test never failed.

However, failed a few times locally when experimenting with bad code.

(cherry picked from commit a01c673)
@nvartolomei @vbotbuildovich
archival: keep locks until outcome is known
8738d48 
(cherry picked from commit 69a5f70)
@vbotbuildovich vbotbuildovich added this to the v24.1.x-next milestone Jul 19, 2024
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jul 19, 2024
@piyushredpanda
Copy link
Contributor

Known failures: #16005 and #19789

@piyushredpanda piyushredpanda merged commit 2006379 into redpanda-data:v24.1.x Jul 21, 2024
15 of 18 checks passed
@piyushredpanda piyushredpanda modified the milestones: v24.1.x-next, v24.1.12 Jul 22, 2024
@BenPope BenPope mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyushredpanda piyushredpanda piyushredpanda approved these changes

@nvartolomei nvartolomei Awaiting requested review from nvartolomei

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v24.1.12
Development

Successfully merging this pull request may close these issues.
3 participants
@vbotbuildovich @piyushredpanda @nvartolomei