Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archival: keep locks until outcome is known #21348

Merged
merged 2 commits into from
Jul 19, 2024
Merged

archival: keep locks until outcome is known #21348

merged 2 commits into from
Jul 19, 2024

Conversation

nvartolomei
Copy link
Contributor

@nvartolomei nvartolomei commented Jul 11, 2024 •
edited
Loading

Closes #21315, #20780, #20780, #18254 and many more with bad log lines like the following.

Potentially also covers #18753

New replacement segment has the same size as replaced segment

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@nvartolomei
Copy link
Contributor Author

/dt

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jul 11, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/51371#0190a310-3c2b-4956-93c5-3471a1b0b94b

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/51725#0190c639-0443-440a-a28e-b967db3509ff

@nvartolomei nvartolomei marked this pull request as ready for review July 13, 2024 14:32
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jul 13, 2024 •
edited
Loading

skipped ducktape retry in https://buildkite.com/redpanda/redpanda/builds/51466#0190acc7-9edd-471c-b7c4-a71ee7670b35:
pandatriage cache was not found

skipped ducktape retry in https://buildkite.com/redpanda/redpanda/builds/51466#0190acdd-5d7b-4401-9bc4-ceed9a19b020:
pandatriage cache was not found

skipped ducktape retry in https://buildkite.com/redpanda/redpanda/builds/51492#0190b2c8-d491-459a-b030-1d9042dece8d:
pandatriage cache was not found

skipped ducktape retry in https://buildkite.com/redpanda/redpanda/builds/51492#0190b2c8-d48f-42b8-96fa-50bb958c5763:
pandatriage cache was not found

@piyushredpanda
Copy link
Contributor

/ci-repeat 1

@nvartolomei
archival/tests: fix use-after-heap in case of failure
a01c673 
We never saw it as the test never failed.

However, failed a few times locally when experimenting with bad code.
@nvartolomei
archival: keep locks until outcome is known
69a5f70
@nvartolomei nvartolomei merged commit c0bd0dd into redpanda-data:dev Jul 19, 2024
19 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.3.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-21348-v23.3.x-95 remotes/upstream/v23.3.x
git cherry-pick -x a01c673311623fb5499eed73d9b7e7743da67365 69a5f70359e60f2a4a0239e53fef42c38d8460ba

Workflow run logs.

This was referenced Jul 19, 2024
Open
Closed
Merged
@Lazin Lazin mentioned this pull request Jul 23, 2024
Closed
@WillemKauf WillemKauf mentioned this pull request Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lazin Lazin Lazin approved these changes

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Failure (key symptom) in ManyPartitionsTest.test_many_partitions_tiered_storage
4 participants
@nvartolomei @vbotbuildovich @piyushredpanda @Lazin