Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix undefined constant ReflectionClassConstant::IS_PUBLIC in php 7.x #1474

Merged
merged 1 commit into from
Dec 13, 2021
Merged

[Core] Fix undefined constant ReflectionClassConstant::IS_PUBLIC in php 7.x #1474

merged 1 commit into from
Dec 13, 2021

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 13, 2021 •
edited
Loading

@samsonasik
Copy link
Member Author

/cc @W0rma

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik samsonasik changed the title [Core] Fix undefined constant ReflectionClassConstant::IS_PUBLIC [Core] Fix undefined constant ReflectionClassConstant::IS_PUBLIC in php 7.x Dec 13, 2021
@TomasVotruba TomasVotruba merged commit 2bde6b3 into main Dec 13, 2021
@TomasVotruba TomasVotruba deleted the fix-6864 branch December 13, 2021 11:56
@TomasVotruba
Copy link
Member

Thank you 👍

@W0rma
Copy link

W0rma commented Dec 13, 2021

@samsonasik Thank you very much! 👍

This was referenced Dec 18, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v0.12.7 breaks compatibility with PHP 7.4 in ConfigureCallValuesCollector
3 participants
@samsonasik @TomasVotruba @W0rma