Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.12.7 breaks compatibility with PHP 7.4 in ConfigureCallValuesCollector #6864

Closed
W0rma opened this issue Dec 13, 2021 · 5 comments · Fixed by rectorphp/rector-src#1474
Closed
Labels

Comments

@W0rma
Copy link

W0rma commented Dec 13, 2021

7e7a90f28649e8be78c0b77efb404dd2a62f157f started using ReflectionClassConstant::IS_PUBLIC in Rector\Core\DependencyInjection\Collector\ConfigureCallValuesCollector which is not available prior to PHP 8.0.

This leads to the following error when running rector on PHP 7.4:

[ERROR] Undefined class constant 'IS_PUBLIC'
@W0rma W0rma added the bug label Dec 13, 2021
@samsonasik
Copy link
Member

You can update the configurable with direct ->configure() call, like this laminas/laminas-servicemanager-migration@35f33f6

@samsonasik
Copy link
Member

It seems check constant exists still needed

@samsonasik
Copy link
Member

samsonasik commented Dec 13, 2021

It seems we need to have rule to downgrade usage of ReflectionClassConstant IS_PUBLIC, IS_PROTECTED, and IS_PRIVATE constant, ref https://3v4l.org/BdMKK

@TomasVotruba
Copy link
Member

It seems we need to have rule to downgrade usage of ReflectionClassConstant IS_PUBLIC, IS_PROTECTED, and IS_PRIVATE constant, ref 3v4l.org/BdMKK

👍 Could you make issue/PR for it?

@samsonasik
Copy link
Member

I will try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants