Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add activeFontStyle prop #88

Merged
merged 3 commits into from
May 30, 2020
Merged

Conversation

Naturalclar
Copy link
Member

@Naturalclar Naturalclar commented May 30, 2020

Overview

  • removed textColor and activeTextColor props
  • added color attribute in fontStyle prop
  • Added an activeFontStyle props which contains color, fontSize, and fontFamily for active State
  • added a default color for selected segment, so the tint color won't cover the text when no text color is set.
  • added fontFamily support for android and web

Test Plan

Tested on iOS/Android simulator

@Naturalclar
Copy link
Member Author

Naturalclar commented May 30, 2020

@arjndr @kesha-antonov
I've changed up the props a bit from #87 and simplified the props a bit. What do you think?

Now theres a fontStyle prop that can take color, fontWeight, and fontSize,
and if you want a separate style for selected segment, you can also use activeFontStyle to override the fontStyle for selected segment.

If you have any suggestions, let me know.

@arjndr
Copy link
Contributor

arjndr commented May 30, 2020

Way better! Easier to understand too, +1 on this

@Naturalclar Naturalclar merged commit d79aed7 into 2.0.0 May 30, 2020
@Naturalclar Naturalclar deleted the feat/addActiveFontStyle branch May 30, 2020 14:21
@kesha-antonov
Copy link
Contributor

@Naturalclar thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants