Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds fontFamily support on iOS, Closes #85 #87

Merged
merged 1 commit into from
May 30, 2020
Merged

feat: Adds fontFamily support on iOS, Closes #85 #87

merged 1 commit into from
May 30, 2020

Conversation

arjndr
Copy link
Contributor

@arjndr arjndr commented May 29, 2020

Overview

Adds fontFamily support on iOS

Test Plan

Tested on iOS simulator

@arjndr arjndr mentioned this pull request May 29, 2020
Closed
@kesha-antonov
Copy link
Contributor

Great!

@Naturalclar
Copy link
Member

Looks great! I'll add support for android/web and release a next version.
This would introduce a breaking change (fontSize -> fontStyle), but I prefer it this way instead of adding multiple props. :D
I'll try to release a new version this weekend.

@Naturalclar Naturalclar changed the base branch from master to 2.0.0 May 30, 2020 08:14
@Naturalclar Naturalclar merged commit fefc0a5 into react-native-segmented-control:2.0.0 May 30, 2020
@Naturalclar Naturalclar mentioned this pull request May 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arjndr @kesha-antonov @Naturalclar