Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local clusterctl overrides for determining latest version for provider #751

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Sep 23, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #599
Fixes #691

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
api/v1alpha1/conditions_consts.go Show resolved Hide resolved
internal/sync/provider_sync.go Outdated Show resolved Hide resolved
furkatgofurov7
furkatgofurov7 previously approved these changes Sep 24, 2024
salasberryfin
salasberryfin previously approved these changes Sep 24, 2024
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

salasberryfin
salasberryfin previously approved these changes Sep 24, 2024
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@furkatgofurov7
Copy link
Contributor

@salasberryfin can you please re-approve?

@Danil-Grigorev Danil-Grigorev merged commit add8810 into rancher:main Sep 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants