🌱 Make latest check optional behind followLatest field #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
follow-latest-selector
branch
from
5da5166
to
1a9c5c4
Compare
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
follow-latest-selector
branch
from
1a9c5c4
to
ed8ee5a
Compare
alexander-demicev
approved these changes
Aug 30, 2024
|
@Danil-Grigorev there is conflict now in Makefile |
furkatgofurov7
approved these changes
Sep 2, 2024
|
@Danil-Grigorev can you take a look at the conflicts on this pr? |
|
Alternative overrides based implementation is merged #751, this can be closed, and followed-up with upstream implementation for determining non-overriden images version - kubernetes-sigs/cluster-api-operator#605 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follow up on #673. This change allows to selectively enable
followLatestversion behavior by setting the field in the spec. The behavior will be enabled by default forrancher/turtlesCAPIProvidersshipped with the helm chart installation, but will need a UI support, in order to set this field.Latest version is determined and limited by the state of the
clusterctl.yamlfile, preventing occasions of unbounded latest version installation, and so always follows the max version from theclusterctl-configConfigMap.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #691
Special notes for your reviewer:
Checklist: