Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics-server chart and images #432

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

manuelbuil
Copy link
Contributor

This PR updates the metrics-server images to v0.7.1 and makes a big version bump on the chart, which was pretty old.

Chart-update relevant changes:

  • Starts consuming the tarball from the https://github.com/kubernetes-sigs/metrics-server/releases
  • We don't need to carry patches on clusterrole.yaml and api-service.yaml anymore because the changes are already in the upstream code.
  • We reduced the patches in deployment.yaml because some are already in the upstream code.
  • tests is removed.
  • Some manifests changed names, e.g. metrics-server-deployment.yaml.patch is now deployment.yaml

Three changes to remember (in case of issues):
1 - We were using --kubelet-preferred-address-types=InternalIP since upstream did not define anything there. Now upstream uses --kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname as default. I left what upstream uses as InternalIP is still prioritized.
2 - We were using priorityClassName: system-node-critical since upstream had that, even though it was commented. Now upstream uses priorityClassName: system-cluster-critical as default. I left what upstream uses even though system-node-critical is the highest priority.
3 - Note that upstream clusterrole now includes "confimaps" and does not include "nodes/stats". I decided to keep what's upstream

Signed-off-by: Manuel Buil <mbuil@suse.com>
@manuelbuil manuelbuil requested a review from a team as a code owner April 1, 2024 09:58
@manuelbuil manuelbuil merged commit da1a371 into rancher:main-source Apr 2, 2024
1 check passed
@manuelbuil manuelbuil deleted the updateMetricsServer branch April 2, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants