Update metrics-server chart and images #432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the metrics-server images to v0.7.1 and makes a big version bump on the chart, which was pretty old.
Chart-update relevant changes:
Three changes to remember (in case of issues):
1 - We were using
--kubelet-preferred-address-types=InternalIP
since upstream did not define anything there. Now upstream uses--kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname
as default. I left what upstream uses as InternalIP is still prioritized.2 - We were using
priorityClassName: system-node-critical
since upstream had that, even though it was commented. Now upstream usespriorityClassName: system-cluster-critical
as default. I left what upstream uses even though system-node-critical is the highest priority.3 - Note that upstream clusterrole now includes "confimaps" and does not include "nodes/stats". I decided to keep what's upstream