Enhancement internal external urls #647

BenjamenMeyer · 2016-07-13T19:00:11Z

Add support for Internal URLs in addition to the Public URLs, by default they are the same; external APIs can make the different if desired.
Use the Service ID as the unique identifier instead of the Service Name
Add remaining infrastructure or correct existing infrastructure to support the implementation of the RESTful interfaces for the OSKSCATALOG and related OSKSADM extensions; corrections were due to better understandings of the extensions during RESTful implementation.
Add RESTful interfaces for the OSKSCATALOG extension, and a couple OSKSADM extension interfaces related to the same support
OSKSCATALOG/OSKSADM functionality is supported both globally (all users) and for specific tenants

- Added ability to get the listing of External APIs from MimicCore - Added ability to remove an External API from MimicCore - Added a couple functional interfaces to the requirements of the IEndPointTemplate interface - Added support for HTTP conflict and unauthorized responses for Identity. - Added a new EndpointTemplateStore to manage a single instance of an IEndPointTemplate. - Add a MIMIC-OS-KSCATALOG extension to Identity for listing/creating/deleting external API services within Mimic - Start support of OS-KSCATALOG extension; mapped out the end-point template support, implementing just the listing and initial auth.

…oskscatalog_endpoint_templates Conflicts: mimic/imimic.py mimic/test/dummy.py mimic/test/test_identity_objects.py

- Add Endpoint template support and associated tests - Added requirement that the Endpoint Template's service type must match that of the ExternalApiStore that is hosting it.

…oskscatalog_endpoint_templates Conflicts: mimic/test/test_identity_objects.py

- bugfix: fix formatting per lint - bugfix: forgot to check in some code for model/idenity_objects.py in last real commit (before merges) - bugfix: correct the coverage report so that developers can see same precision as codecov.io generates for github PR gate checking

- add implementation for the RESTful API to update a template - refactor: put the verb in test object's setUp since all the test functions use the same HTTP verb - add missing test for service deletion

- Refactored the service management MIMIC-OSKSCATALOG API to be a variation of the OS-KSADM Keystone Extension. There are some differences which are documented in the REST interface.

…oskscatalog_endpoint_templates - Updated tests for some of the changes

- API was written as a single JSON-based API; but template id needed to be a parameter to two of the operations (update, and delete).

- Added the endpoint for removing an external API template - Removed some header lines that were there fore debug purposes. - Moved get_template_id() from test_identity_oskscatalog to helpers - Added support for a 'has_template' to ExternalApiStore in order to speed up finding the API that owned a given template id.

- Added support for the OS-KSCATALOG Tenant-Specific List Endpoints - Changed the Endpoint Template serialization to support serializing for a tenant as the information is a little different. - Updated existing OS-KSCATALOG support to include the 'links' section. The limit/marker support is not implemented but this at least makes the JSON structure compliant. (Note: there is not information on what the internals of the 'links' should look like.) - Added or updated tests as appropriate for the above

- Enhancement: Require all APIs to have unique template ids across every API. - Enhancement: Implement REST API for enabling a specific template id for a specific tenant. - Bug Fix: template id - Add + update tests accordingly

- Added REST API to disable a template for a tenant. - Does not affect globally enabled templates. - Template must first have been enabled for the tenant.

…s only - The documentation does not explicitly say to, but the examples imply that the list of templates returned when listing for a specific tenant should be limited to only those that are enabled for the tenant.

- Also provide internal URLs in the service catalog.

- Correct the error message regarding the sharing the same UUID on add to generate a conflict error message regarding the UUID instead of on the name - Don't allow two externals APIs to share the same display name

- Provide the ability to put %tenant_id% (or a template provided variation) into the URLs of the External APIs and switch it out with the tenant-id when providing it in the service catalog. Note: One of the tests seems to have a weird side-effect making other tests fail. The test was amended to reset some values after finishing the test. A better solution is desirable.

- Correct bug in making example API instances where the default could end up being a global instance instead of a test-specific instance

Conflicts: mimic/model/identity_objects.py mimic/test/dummy.py

- added test to cover another branch of the code - updated the docstring on a test to better clarify its use-case - renamed a test to clarify it and order it in the output properly

- updated variable names to comply with the code for continuity

codecov-io · 2016-07-13T21:30:08Z

Current coverage is 99.55% (diff: 99.67%)

Merging #647 into master will decrease coverage by <.01%

@@             master       #647   diff @@
==========================================
  Files            78         78          
  Lines          5225       5402   +177   
  Methods           0          0          
  Messages          0          0          
  Branches        721        772    +51   
==========================================
+ Hits           5202       5378   +176   
  Misses           10         10          
- Partials         13         14     +1

Powered by Codecov. Last update a57eb39...b251793

- Made some comments clearer - Switched around some logic to make it simpler, easier to follow, and easier to test. - Corrected a couple tests to increase code coverage - Added a few missing tests

BenjamenMeyer · 2016-07-14T20:03:40Z

Note: 2194 of the new lines are for tests.

BenjamenMeyer · 2016-07-14T20:06:35Z

@glyph sorry for the size - this should make the new functionality usable by all.

glyph · 2016-07-19T01:21:56Z

@BenjamenMeyer - +3k? Jeez. Is there any way to split this up?

BenjamenMeyer · 2016-07-19T14:16:49Z

@glyph if y'all promise to do reviews faster then I'll push it in a series (PR #648 being the first in that series). The series will consist of 4 parts:

More infrastructure (PR Enhancement: Infrastructure in support of the External API support #648)
OS-KSADM Service Registration
OS-KSCATALOG Endpoint Template for All
OS-KSCATALOG Endpoint Template for Tenant

I am concerned that code coverage may not be quite up to par in the individual parts of the series.

glyph · 2016-07-19T19:17:35Z

@BenjamenMeyer Review speed is largely a function of PR size :). Small PRs that I can easily absorb in one sitting will definitely get reviewed faster. A 3K line PR is going to need to wait until I have an entire day set aside for Mimic only, which is likely to push it out weeks or more. I think you noticed a big gap because I was at conferences, then on vacation, and the other primary maintainer is on maternity leave, so there was just nobody left to do anything. I look at the PR list every day that I'm at work.

BenjamenMeyer · 2016-07-19T19:41:33Z

@glyph understood; as I said - I'm happy to break it down to smaller PRs if it helps to make things go faster.

BenjamenMeyer · 2016-07-19T19:43:06Z

#648 fully ready for review

BenjamenMeyer · 2016-07-22T14:01:03Z

Note: Keeping this hear until it's completed in merges via other PRs.

Added the ☔ to denote it's coverage as such.

This reverts commit 9179211.

This reverts commit 37e410e.

BenjamenMeyer added 24 commits May 13, 2016 19:14

Merge branch 'master' into enhancement_oskscatalog_endpoint_templates

b2930a6

Cleanups per feedbacks on predecessor branch

75c375c

Merge branch 'enhancement_iexternalapitemplatemock' into enhancement_…

69eb8f3

…oskscatalog_endpoint_templates Conflicts: mimic/imimic.py mimic/test/dummy.py mimic/test/test_identity_objects.py

Enhancement: Add Endpoint Templates

3b869aa

- Add Endpoint template support and associated tests - Added requirement that the Endpoint Template's service type must match that of the ExternalApiStore that is hosting it.

Merge branch 'enhancement_iexternalapitemplatemock' into enhancement_…

5e90623

…oskscatalog_endpoint_templates Conflicts: mimic/test/test_identity_objects.py

Enhancement: Implement Update Template

2cfb3d2

- add implementation for the RESTful API to update a template - refactor: put the verb in test object's setUp since all the test functions use the same HTTP verb - add missing test for service deletion

Refactor: Changed MIMIC-OSKSCATALOG to OS-KSADM

c2b8d42

- Refactored the service management MIMIC-OSKSCATALOG API to be a variation of the OS-KSADM Keystone Extension. There are some differences which are documented in the REST interface.

Merge branch 'enhancement_iexternalapitemplatemock' into enhancement_…

5532466

…oskscatalog_endpoint_templates - Updated tests for some of the changes

Refactor: REST API Correction

63bfc5b

- API was written as a single JSON-based API; but template id needed to be a parameter to two of the operations (update, and delete).

Enhancement: Disable template for tenant

4a8d549

- Added REST API to disable a template for a tenant. - Does not affect globally enabled templates. - Template must first have been enabled for the tenant.

Refactor: Use id as key instead of name for external APIs

8b625b7

Enhancement: Also provide Internal URLs

913c65a

- Also provide internal URLs in the service catalog.

Bug Fix: Adding duplicative external APIs

ddc7180

- Correct the error message regarding the sharing the same UUID on add to generate a conflict error message regarding the UUID instead of on the name - Don't allow two externals APIs to share the same display name

Bug Fix: make_example_external_api()

c0fe4be

- Correct bug in making example API instances where the default could end up being a global instance instead of a test-specific instance

Merge branch 'master' into enhancement_internal-external_urls

f21969b

Conflicts: mimic/model/identity_objects.py mimic/test/dummy.py

Cleanup: Remove unused FORBIDDEN response

7b4a728

Enhancement: more testing

d9bb283

- added test to cover another branch of the code - updated the docstring on a test to better clarify its use-case - renamed a test to clarify it and order it in the output properly

BenjamenMeyer self-assigned this Jul 13, 2016

BenjamenMeyer added enhancement needed by: cloud backup work in progress labels Jul 13, 2016

Bug Fix: variable naming

e701589

- updated variable names to comply with the code for continuity

Bug Fix: Code coverage

b251793

- Made some comments clearer - Switched around some logic to make it simpler, easier to follow, and easier to test. - Corrected a couple tests to increase code coverage - Added a few missing tests

BenjamenMeyer added ready for review and removed work in progress labels Jul 14, 2016

BenjamenMeyer pushed a commit to BenjamenMeyer/mimic that referenced this pull request Jul 19, 2016

PR rackerlabs#647 Break Down rackerlabs#1

37e410e

BenjamenMeyer pushed a commit to BenjamenMeyer/mimic that referenced this pull request Jul 19, 2016

PR rackerlabs#647 Break Down #1a

9179211

BenjamenMeyer mentioned this pull request Jul 19, 2016

Enhancement: Infrastructure in support of the External API support #648

Merged

BenjamenMeyer added the ☂ label Jul 19, 2016

Merge branch 'master' into enhancement_internal-external_urls

59bb98d

BenjamenMeyer added 2 commits July 29, 2016 18:04

Merge branch 'master' into enhancement_internal-external_urls

7e36157

Merge branch 'master' into enhancement_internal-external_urls

f3fa3a4

glyph merged commit f3fa3a4 into rackerlabs:master Aug 10, 2016

BenjamenMeyer pushed a commit to BenjamenMeyer/mimic that referenced this pull request Aug 23, 2016

Revert "PR rackerlabs#647 Break Down #1a"

f2d3acd

This reverts commit 9179211.

BenjamenMeyer pushed a commit to BenjamenMeyer/mimic that referenced this pull request Aug 23, 2016

Revert "PR rackerlabs#647 Break Down rackerlabs#1"

00a0aa9

This reverts commit 37e410e.

BenjamenMeyer mentioned this pull request Aug 23, 2016

Enhancement restore external api restful interface #665

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancement internal external urls #647

Enhancement internal external urls #647

BenjamenMeyer commented Jul 13, 2016 •

edited

Loading

codecov-io commented Jul 13, 2016 •

edited

Loading

BenjamenMeyer commented Jul 14, 2016

BenjamenMeyer commented Jul 14, 2016

glyph commented Jul 19, 2016

BenjamenMeyer commented Jul 19, 2016 •

edited

Loading

glyph commented Jul 19, 2016

BenjamenMeyer commented Jul 19, 2016

BenjamenMeyer commented Jul 19, 2016

BenjamenMeyer commented Jul 22, 2016

Enhancement internal external urls #647

Enhancement internal external urls #647

Conversation

BenjamenMeyer commented Jul 13, 2016 • edited Loading

codecov-io commented Jul 13, 2016 • edited Loading

Current coverage is 99.55% (diff: 99.67%)

BenjamenMeyer commented Jul 14, 2016

BenjamenMeyer commented Jul 14, 2016

glyph commented Jul 19, 2016

BenjamenMeyer commented Jul 19, 2016 • edited Loading

glyph commented Jul 19, 2016

BenjamenMeyer commented Jul 19, 2016

BenjamenMeyer commented Jul 19, 2016

BenjamenMeyer commented Jul 22, 2016

BenjamenMeyer commented Jul 13, 2016 •

edited

Loading

codecov-io commented Jul 13, 2016 •

edited

Loading

BenjamenMeyer commented Jul 19, 2016 •

edited

Loading