Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First take #1

Merged
merged 3 commits into from
Oct 22, 2013
Merged

First take #1

merged 3 commits into from
Oct 22, 2013

Conversation

lekhajee
Copy link
Contributor

No description provided.

manishtomar
manishtomar reviewed Oct 21, 2013
View reviewed changes
mimic/json_schema/auth_schema.py
"endpoints": [{"region": "ORD",
"tenantId": "851153",
"publicURL": "http://localhost:8080/v2/851153/loadbalancers"}],
"type": "rax:load-balancer"}]}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to return autoscale endpoint too? AFAIK, otter and bobby don't need it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I was thinking not cause the the same reason.

@manishtomar
Copy link
Contributor

Can the json_schema/ directory be renamed to something else like just json/ since it is not containing schema? Maybe you've a better name in mind?

@cyli
Copy link
Contributor

cyli commented Oct 21, 2013

@manishtomar agree. Also wondering if the auth and nova mocks should be on separate services, or maybe at least under a different subpath? I don't think nova and auth have any overlapping endpoints, but possibly load balancers may overlap with one or the other? This can be done in a different PR though.

@lekhajee
Copy link
Contributor Author

updated folder names. Will change auth, nova to be separate services in the next PR and might need your help :)

@manishtomar
Copy link
Contributor

+1 LGTM

lekhajee added a commit that referenced this pull request Oct 22, 2013
@lekhajee
Merge pull request #1 from rackerlabs/first-take
1e5435b 
First take
@lekhajee lekhajee merged commit 1e5435b into master Oct 22, 2013
@cyli
Copy link
Contributor

cyli commented Oct 22, 2013

@lekhajee happy to!

@lekhajee lekhajee deleted the first-take branch September 18, 2014 21:08
@ayersek64 ayersek64 mentioned this pull request Oct 2, 2015
Closed
tawalton added a commit that referenced this pull request Oct 29, 2015
@tawalton
Merge pull request #1 from tawalton/add_humans
fd89261 
added humans.txt file
BenjamenMeyer pushed a commit to BenjamenMeyer/mimic that referenced this pull request Jul 19, 2016
PR rackerlabs#647 Break Down rackerlabs#1
37e410e
@glyph glyph mentioned this pull request Jul 20, 2016
Merged
BenjamenMeyer pushed a commit to BenjamenMeyer/mimic that referenced this pull request Aug 23, 2016
Revert "PR rackerlabs#647 Break Down rackerlabs#1"
00a0aa9 
This reverts commit 37e410e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lekhajee @manishtomar @cyli