Reduce flakiness of certain Common Test suites #10364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
flaky-mc-flake-flake
branch
from
1b486cb
to
9a71595
Compare
It could help, we'll see.
During shutdown it is possible that the stream coordinator lives beyond the khepri meta data store which causes rabbit_nodes:list_members/0 to return the empty list which in turn could cause the stream coordinator to make incorrect cluster changes. This commit handles those two cases.
per_message_ttl test woudl publish a message with a short ttl then assert on info counters. On a slow system it is possible that the message expires before the test could observe the counter change.
michaelklishin
changed the title
kjnilsson
force-pushed
the
flaky-mc-flake-flake
branch
from
4480e13
to
3d74945
Compare
As writing to a file isn't atomic between opening and writing this can happen and would unnecessarily return the :garbage_in_pid_file error.
kjnilsson
force-pushed
the
flaky-mc-flake-flake
branch
from
d5d21bf
to
60f9f3c
Compare
Stream deletes aren't necessarily fully complete by the time the queue.delete command returns as the stream coordinator will do this work async. By using unique queue names we avoid the need to do additional polling / waiting for teh delete operation to be fully completed.
The leader_locator_balanced_random_maintenance test is effectively using a plain random approach so we cannot assert that there definitely would be leaders on both potential nodes only that there aren't any leaders on the node that is in maintenance mode.
kjnilsson
force-pushed
the
flaky-mc-flake-flake
branch
from
d29f28b
to
d15aadf
Compare
|
Awesome! Just out of curiosity, let's see if this backports to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variety of flaky test improvement and smaller bug fixes:
Bug fixes:
rabbit_nodes:list_running/0returns[]whenever there is a failure so this PR also handles a few cases where that could cause unwanted side effects. This will be changed in a future version of the API.