Stream coordinator: fixes to automatic membership changes. #10331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various bug fixes to make stream coordinator membership changes more reliable. Previously various errors could happen as well as partially successful attempts where the membership change command may fail but it leaves the new server running. Also ensure that stream coordinator members are removed as part of the forget_cluster_node command. Add stream coordinator status command. To show the raft status of the stream coordinator just like is done for quorum queues.
kjnilsson
force-pushed
the
stream-coordinator-fixes
branch
from
461c746
to
71e7c33
Compare
Don't do clustering with mixed versions anyway. Please.
Also refactor to avoid double read of queue record.
And fix a race condition flake in amqp10_client_SUITE.
dumbbell
reviewed
Jan 25, 2024
dumbbell
reviewed
Jan 25, 2024
kjnilsson
force-pushed
the
stream-coordinator-fixes
branch
from
ec6ce97
to
dd16b7e
Compare
acogoluegnes
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various bug fixes to make stream coordinator membership changes more reliable. Previously various errors could happen as well as partially successful attempts where the membership change command may fail but it leaves the new server running.
Also ensure that stream coordinator members are removed as part of the
forget_cluster_nodecommand.Also added
rabbitmq-streams coordinator_statuscommand so that we can get a view of replication and other information in a nice tabular format, same asrabbitmq-queues quorum_statusThis PR also contains a change to allow
rabbit_nodes:list_member/0to return[](rather than[node()]) when the query to fetch the current members fails. This allows us to detect this scenario in the code and avoid, e.g. shrinking the coordinator cluster incorrectly.Also adding back a missing clause in the quorum queue tick handler that was accidentally removed in #10364