Fix bug for circuit with selected measurement result #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter measure_results was not correctly processed in QubitCircuit.run because the Simulator is initialized twice. This commit removes the parameters state, cbits and measure_results from the __init__ of CircuitSimulator and only initialize the simulator before it is run. The CircuitSimulator class should only include information about the circuit while the information about the state is only provided when running the simulation.
hodgestar
approved these changes
Sep 7, 2022
BoxiLi
added a commit
to BoxiLi/qutip-qip
that referenced
this pull request
Oct 23, 2022
* Fix bug for circuit with selected measurement result The parameter measure_results was not correctly processed in QubitCircuit.run because the Simulator is initialized twice. This commit removes the parameters `state`, `cbits` and `measure_results` from the `__init__` of CircuitSimulator and only initializes the simulator before it is run. The CircuitSimulator class should only include information about the circuit while the information about the state is only provided when running the simulation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter measure_results was not correctly processed in QubitCircuit.run because the Simulator is initialized twice. This commit removes the parameters state, cbits and measure_results from the
__init__of CircuitSimulator and only initializes the simulator before it is run.The CircuitSimulator class should only include information about the circuit while the information about the state is only provided when running the simulation.
Fix #164