Final time calculation in _concatenate_pulses.
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI fails due to the error that is fixed in this PR: #163 |
|
@christian512 Do you have a test we can add for this? |
|
This is very strange... I think they should be either all lists or all arrays. Let me have a closer look at it. |
|
Yes, you are right. It wasn't showing up because in most of the examples all the sub @christian512 do you mind if I push to this branch? |
@BoxiLi Christian is on holiday this week, so I think he is fine with you pushing to this branch at the moment. |
…l_time_calculation
Test against compilation routines, where different sampling numbers are used in different gates.
BoxiLi
added a commit
to BoxiLi/qutip-qip
that referenced
this pull request
Oct 23, 2022
Fix the final time calculation in `_concatenate_pulses`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation of
final_timewas done by taking the last element of thetlistincompiled_tlist. However, the elements incompiled_tlistare again lists, where the first element is just a list and the second element are the actual times.E.g.
tlist = [[0.0], np.array([...])]So we have to take the second ( i.e. last) element from that and then the last element to get the largest time.
The previous version sometimes produced errors when using
processor.load_circuit(...).