QIP Notebooks #42
Merged
QIP Notebooks #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoxiLi
approved these changes
Sep 25, 2022
There was a problem hiding this comment.
All work well for me.
One thing that is not related to this PR. By installing in a fresh environment following environment.yml, cython is not included, because it is not by default included as a dependency of qutip. But in qutip.ipynbtools cython is explicitly imported (to get the version). So all commands like from qutip.ipynbtools import version_table will fail. Maybe cython should be included explicitly in environment.yml?
This was referenced Sep 25, 2022
|
@BoxiLi Thank you for reviewing. I created an issue on this repository for adding Cython to the environment.yml and another in QuTiP for fixing qutip.ipynbtools in dev.major. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the tutorials for the
qutip_qippackage to the new tutorials repository. Only minor changes where applied after taking the notebooks from https://github.com/qutip/qutip-notebooks.