-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Liquibase includeAll in Native Image #42095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! I added a small nitpick about packages but I will let @zakkak have a look as I'm not very familiar with this GraalVM feature.
import liquibase.resource.PathResource; | ||
import liquibase.resource.Resource; | ||
|
||
public class NativeImageResourceAccessor extends AbstractPathResourceAccessor { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one needs to be in the runtime
subpackage as it's not API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
5d108be
to
3349324
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please have a look at the suggestion regarding the method detecting if we are in a native image.
extensions/liquibase/runtime/src/main/java/io/quarkus/liquibase/LiquibaseFactory.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gcw-it thank you. Could you please also squash the two commits?
Done. |
Status for workflow
|
Fixes #16292
This patch creates a
FileSystem
in the native image to enable access to the Liquibase changelog resources.