Liquibase includeAll does not work in native mode

[famod]

This is a follow-up to #14751 which contains all the necessary info, especially #14751 (comment)

Short story: includeAll was fixed for JVM mode by upgrading to Liquibase to 4.3.2 but the classpath resource scanning in Liquibase needs some adjustments (in Quarkus) to make it work in native.

[quarkus-bot]

/cc @andrejpetras, @geoand, @gsmet

[geoand]

Do we have an example application where this isn't working?

Or some easy way to reproduce it?

[famod]

Two options to reproduce:

• run the IT from Extend Liquibase IT with includeAll #16293 (and flip that flag)
• use the sampleproject from Liquibase includeall only works in dev mode #14751 (which is about JVM mode, so native bits have to be added)

[geoand]

So I had a quick look at this one, and it seems that the way includeAll works (which is by reading the contents of the actual directory file), does not work well in GraalVM.
I even tried registering the directory as a resource (which worked with a small fix in Quarkus), but that still didn't do the trick.

So if we want to make this work, we'll need to change the Liquibase implementation to not open the directory as a stream, but instead I guess filter the files of the file system.

[famod]

Thanks for looking into this @geoand! I had a feeling that it would turn out this way.

@nvoxland would you be open to making Liquibase more GraalVM friendly?
If yes we would create an upstream issue to track this.

[famod]

FTR, liquibase 4.6.0 tightened the validation in that errorIfMissingOrEmpty is now set to true by default, causing a hard failure (directory not found).
See also: #24487 (comment)

[JimJLE]

Still not working with 2.16.5.Final
Dev and JVM mode ok but not with native apps.
Is there any bypass ?

[geoand]

Is this still an issue in the latest versions of Quarkus?

[famod]

Just checked the IT on main - still an issue, unfortunately.

[geoand]

😢

Thanks for checking