-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix encoding of '?' in query parameter values by Encode.encodeQueryParam(..) #41062
Fix encoding of '?' in query parameter values by Encode.encodeQueryParam(..) #41062
Conversation
964b238
to
f524a64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This comment has been minimized.
This comment has been minimized.
…ram(..) Previously `?` in query parameter values where encoded as is which caused invalid URL values. We now replace `?` characters in query parameter values with `%3F`. Fixes quarkusio#41060 Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
f524a64
to
f244de0
Compare
I fixed the small formatting issue and force pushed. |
Status for workflow
|
See #41060 (comment) it's possible that this fix is actually wrong. |
Previously
?
in query parameter values where encoded as is which caused invalid URL values. We now replace?
characters in query parameter values with%3F
.Fixes #41060