Fix encoding of '?' in query parameter values by Encode.encodeQueryPa…

…ram(..) Previously `?` in query parameter values where encoded as is which caused invalid URL values. We now replace `?` characters in query parameter values with `%3F`. Fixes #41060 Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
quarkusio · Jun 7, 2024 · 964b238 · 964b238
1 parent f17c985
commit 964b238
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/...reactive/common/runtime/src/main/java/org/jboss/resteasy/reactive/common/util/Encode.java b/...reactive/common/runtime/src/main/java/org/jboss/resteasy/reactive/common/util/Encode.java
@@ -95,7 +95,9 @@ public class Encode {
                 case '.':
                 case '_':
                 case '~':
+                    continue;
                 case '?':
+                    queryNameValueEncoding[i] = "%3F";
                     continue;
                 case ' ':
                     queryNameValueEncoding[i] = "+";

diff --git a/...tive/common/runtime/src/test/java/org/jboss/resteasy/reactive/common/util/EncodeTest.java b/...tive/common/runtime/src/test/java/org/jboss/resteasy/reactive/common/util/EncodeTest.java
@@ -15,4 +15,11 @@ void encodeEmoji() {
         assertEquals(encodedEmoji, Encode.encodePath(emoji));
         assertEquals(encodedEmoji, Encode.encodeQueryParam(emoji));
     }
+
+    @Test
+    void encodeQuestionMarkQueryParameterValue() {
+        String uriQueryValue ="bar?a=b";
+        String encoded = URLEncoder.encode(uriQueryValue, StandardCharsets.UTF_8);
+        assertEquals(encoded, Encode.encodeQueryParam(uriQueryValue));
+    }
 }