Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify prune_inferior_points tests against sorting order #2548

Closed
wants to merge 1 commit into from

Commits on Sep 23, 2024

  1. Robustify prune_inferior_points tests against sorting order (pytorch#…

    …2548)
    
    Summary:
    Our nightly CI started failing, likely due to a sorting order change introduced in pytorch/pytorch#127936
    
    This change robustifies the tests against the point order (and also fixes a torch deprecation warning).
    
    NOTE: Even though pytorch/pytorch#127936 was unlanded, getting these changes is will help robustify the tests going forward.
    
    NOTE: As this makes `torch.sort` use `stable=True`, this will come at a slight performance hit. However, the tensor sizes typically involved in `prune_inferior_points` are quite small (order of a few hundred items maybe), so this should be negligible.
    
    Pull Request resolved: pytorch#2548
    
    Test Plan: unit tests
    
    Reviewed By: sdaulton, saitcakmak
    
    Differential Revision: D63260870
    
    Pulled By: Balandat
    Balandat authored and facebook-github-bot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f1ffb7e View commit details
    Browse the repository at this point in the history