Robustify prune_inferior_points tests against sorting order #2548
+20
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Balandat
force-pushed
the
fix_pruning_test_sorting
branch
from
9295acc
to
8cfaee7
Compare
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D63260870 |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
Sep 23, 2024
…2548) Summary: Our nightly CI started failing, likely due to a sorting order change introduced in pytorch/pytorch#127936 This change robustifies the tests against the point order (and also fixes a torch deprecation warning) Pull Request resolved: pytorch#2548 Differential Revision: D63260870 Pulled By: Balandat
Balandat
force-pushed
the
fix_pruning_test_sorting
branch
from
7312cf6
to
22d0a29
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63260870 |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
Sep 23, 2024
…2548) Summary: Our nightly CI started failing, likely due to a sorting order change introduced in pytorch/pytorch#127936 This change robustifies the tests against the point order (and also fixes a torch deprecation warning) Pull Request resolved: pytorch#2548 Differential Revision: D63260870 Pulled By: Balandat
Balandat
force-pushed
the
fix_pruning_test_sorting
branch
from
22d0a29
to
5639e33
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63260870 |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
Sep 23, 2024
…2548) Summary: Our nightly CI started failing, likely due to a sorting order change introduced in pytorch/pytorch#127936 This change robustifies the tests against the point order (and also fixes a torch deprecation warning) Pull Request resolved: pytorch#2548 Reviewed By: sdaulton Differential Revision: D63260870 Pulled By: Balandat
Balandat
force-pushed
the
fix_pruning_test_sorting
branch
from
5639e33
to
96476af
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2548 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 193 193
Lines 17010 17056 +46
=======================================
+ Hits 17007 17053 +46
Misses 3 3 ☔ View full report in Codecov by Sentry. |
…2548) Summary: Our nightly CI started failing, likely due to a sorting order change introduced in pytorch/pytorch#127936 This change robustifies the tests against the point order (and also fixes a torch deprecation warning). NOTE: Even though pytorch/pytorch#127936 was unlanded, getting these changes is will help robustify the tests going forward. NOTE: As this makes `torch.sort` use `stable=True`, this will come at a slight performance hit. However, the tensor sizes typically involved in `prune_inferior_points` are quite small (order of a few hundred items maybe), so this should be negligible. Pull Request resolved: pytorch#2548 Test Plan: unit tests Reviewed By: sdaulton, saitcakmak Differential Revision: D63260870 Pulled By: Balandat
|
This pull request was exported from Phabricator. Differential Revision: D63260870 |
Balandat
force-pushed
the
fix_pruning_test_sorting
branch
from
96476af
to
f1ffb7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our nightly CI started failing, likely due to a sorting order change introduced in pytorch/pytorch#127936
This change robustifies the tests against the point order (and also fixes a torch deprecation warning)