Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Final to typing_extensions #2453

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Add Final to typing_extensions #2453

merged 1 commit into from
Sep 13, 2018

Conversation

ilevkivskyi
Copy link
Member

@ilevkivskyi
Copy link
Member Author

I just merged the corresponding typing PR, so I think this can be merged as well.

@ilevkivskyi ilevkivskyi merged commit 75e13a0 into python:master Sep 13, 2018
@ilevkivskyi ilevkivskyi deleted the final branch September 13, 2018 14:07
@ilevkivskyi
Copy link
Member Author

Oops. It looks like merging this broke master. But I suppose reverting this will not help, because it is a mypy issue.

@srittau
Copy link
Collaborator

srittau commented Sep 13, 2018

@ilevkivskyi: Most likely unrelated, see #2456 .

yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
@ilevkivskyi
Add Final to typing_extensions (python#2453)
5e37ba9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@JukkaL JukkaL Awaiting requested review from JukkaL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilevkivskyi @srittau @JelleZijlstra