Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate CI failures #2456

Closed
srittau opened this issue Sep 13, 2018 · 4 comments
Closed

Investigate CI failures #2456

srittau opened this issue Sep 13, 2018 · 4 comments

Comments

@srittau
Copy link
Collaborator

srittau commented Sep 13, 2018

Lately, some PRs are failing their CI checks with an error that seems unrelated to the PR, see for example #2455 and #2433 and #2436 (although that one also has genuine failures). It looks as if this was a problem with the wrong Python version (2.7 instead of 3.6) to be installed in the path. The only commonality I see between the three pull requests is that all three were submitted by Google employees, but that seems to be incidental.
@srittau
Copy link
Collaborator Author

srittau commented Sep 13, 2018

Also #2439, which is not by a Google employee.

@msullivan
Copy link
Contributor

@ethanhs All the failures seem to be when running pep561 tests; any ideas?

@ethanhs
Copy link
Contributor

ethanhs commented Sep 13, 2018

@msullivan this is likely from python/mypy#5578. I will work out what is wrong and fix it tomorrow. Sorry all for the interruption.

This was referenced Sep 13, 2018
Closed
Merged
@srittau
Copy link
Collaborator Author

srittau commented Sep 13, 2018

The problematic change has been rolled back in python/mypy#5615, PRs work again.

@srittau srittau closed this as completed Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srittau @msullivan @ethanhs