Use synchronous ajax in GeoJson #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conengmo
added
the
waiting for changes
Conengmo
added
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1209
Two earlier PRs did conflicting changes: #1190 (merged July 2019) and #1289 (merged April 2020) are at odds with each other. This PR tries to resolve that.
Two requirements:
GeoJsonJS object to its parent after loading the data.GeoJsonJS object to its parent before continuing with the rest of the code.Two make both requirements come true we'll have to make the ajax request that loads the geojson data synchronously.
I added a test case that verifies both requirements are satisfied.