Geojson: fix show=False when not embedding data #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ocefpaf this PR is ready to be merged I think, do you want to take a final look? The issue reporter and I both tested it. |
ocefpaf
approved these changes
Apr 13, 2020
|
Thanks! |
Thank you for keeping the boat afloat! Let me know if you want to issue a new release. |
|
Will do! I hope to get one or two more fixes in, and then I’ll ping you for a release |
This was referenced Jun 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1283.
When we don't embed the data for
GeoJson, it's loaded by ajax request. Currently we add the GeoJson layer to the map at the end of that request, but that leads to issues. The layer is unknown when layer control is initialized. Fix this by adding the layer to the map before the ajax request.