Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append arbitrary args instead of prepending. #4217

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

jameshilliard
Copy link
Contributor

@jameshilliard jameshilliard commented Feb 13, 2024

Summary of changes

Restore original argument append behavior which was changed in #4079.

Fixes:

error: option --dist-dir not recognized

ERROR Backend subprocess exited when trying to invoke build_wheel

Pull Request Checklist

@jameshilliard
Copy link
Contributor Author

Closing in favor of #4218.

@jameshilliard jameshilliard reopened this Feb 21, 2024
@jameshilliard jameshilliard force-pushed the append-arbitrary-args branch 2 times, most recently from 91f3400 to 7f256d4 Compare February 21, 2024 16:57
setuptools/build_meta.py Outdated Show resolved Hide resolved
setuptools/build_meta.py Outdated Show resolved Hide resolved
setuptools/build_meta.py Outdated Show resolved Hide resolved
@abravalheri
Copy link
Contributor

Thank you very much @jameshilliard for working on this.

Would you like to add a regression test so that we don't accidentally break the use case in the future?

@jameshilliard jameshilliard force-pushed the append-arbitrary-args branch 2 times, most recently from 29680f1 to 1f0cefb Compare February 22, 2024 17:55
@jameshilliard
Copy link
Contributor Author

Would you like to add a regression test so that we don't accidentally break the use case in the future?

Test added that should catch this issue.

@abravalheri abravalheri merged commit 5a54d5b into pypa:main Feb 23, 2024
23 checks passed
@abravalheri
Copy link
Contributor

Thank you very much @jameshilliard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants