Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only pass --build-option to bdist_wheel in build_meta #4079

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

abravalheri
Copy link
Contributor

In #2491 (comment) the discussion seems to lead to the idea that it is better for now to avoid passing any --build-option for commands that are not bdist_wheel in setuptools.build_meta.

Summary of changes

  • Only pass config_settings["--build-option"] to bdist_wheel in setuptools.build_meta
  • Remove no longer valid tests for config_settings["--build-option"] and config_settings["--global-option"] and editable installs

Pull Request Checklist

@abravalheri
Copy link
Contributor Author

There was not much feedback on this proposal, so it might be the case people don't feel strong about it.

I think I will go ahead with this change because we had one positive feedback from one of pip's maintainers.

In pypa#2491 (comment)
the discussion seems to lead to the idea that it is better for now
to avoid passing any `--build-option` for commands that are not
`bdist_wheel` in `setuptools.build_meta`.
@jameshilliard
Copy link
Contributor

This appears to have broken the ability to pass arguments to build_ext via config_settings, see #4218 reverting this change.

javajawa added a commit to mewbotorg/mewbot that referenced this pull request Feb 27, 2024
Fix argument order of --config-settings["--build-option"] arguments. This was broken by pypa/setuptools#4079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants