-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patch] replace logger with snippets version #1465
Conversation
i.e. pyiron_base.state.logger.logger with pyiron_snippets.logger.logger. The original location leaves a re-direct for backwards compatibility.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
FFS, is there a flag to stop the damned bot? |
Ok, I tried bypassing the linter by adding |
I thought we agreed to completely remove the classes replaced by |
[minor] remove the backwards compatibility redirects
Yes, but instead of having three compatibility breaking commits, I opted to go for three backwards-compatible patches and then a single PR to remove all the compatibility shortcuts. |
i.e. pyiron_base.state.logger.logger with pyiron_snippets.logger.logger. The original location leaves a re-direct for backwards compatibility.