-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patch] use deprecate from pyiron_snippets #1457
Conversation
@jan-janssen I left it with the backwards compatibility you found confusing -- I'll stack an additional PR on top doing a [minor] bump that removes the compatibility and clarifies the situation |
i.e. pyiron_base.state.logger.logger with pyiron_snippets.logger.logger. The original location leaves a re-direct for backwards compatibility.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
[minor] remove the backwards compatibility redirects
pyiron_base/__init__.py
Outdated
@@ -47,6 +46,7 @@ | |||
|
|||
# Expose snippets references in base API for backwards compatibility | |||
from pyiron_snippets.import_alarm import ImportAlarm | |||
from pyiron_snippets.deprecate import Deprecator, deprecate, deprecate_soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from pyiron_snippets.deprecate import Deprecator, deprecate, deprecate_soon |
[patch] replace logger with snippets version
@jan-janssen going forward I recommend merging stacks from the bottom up instead of the top down -- now this PR is big and it's not immediately clear to me where all the problems are coming from. Diff markup got committed directly though, so that's definitely part of it. |
…_deprecate # Conflicts: # pyiron_base/utils/error.py
No description provided.