(RK-243) Refuse to generate rugged credentials more than 50 times.

lib/r10k/git/rugged/credentials.rb

@@ -12,9 +12,18 @@ class R10K::Git::Rugged::Credentials
   # @param repository [R10K::Git::Rugged::BaseRepository]
   def initialize(repository)
     @repository = repository
+    @called = 0
   end
 
   def call(url, username_from_url, allowed_types)
+    @called += 1
+
+    # Break out of infinite HTTP auth retry loop introduced in libgit2/rugged 0.24.0, libssh
+    # auth seems to already abort after ~50 attempts.
+    if @called > 50
+      raise R10K::Git::GitError.new("Authentication failed for Git remote #{url.inspect}.")
+    end
+
     if allowed_types.include?(:ssh_key)
       get_ssh_key_credentials(url, username_from_url)
     elsif allowed_types.include?(:plaintext)

spec/unit/git/rugged/credentials_spec.rb

@@ -99,5 +99,11 @@
     it "creates default credentials when no other types are allowed" do
       expect(subject.call("https://tessier-ashpool.freeside/repo.git", nil, [])).to be_a_kind_of(Rugged::Credentials::Default)
     end
+
+    it "refuses to generate credentials more than 50 times" do
+      (1..50).each { subject.call("https://tessier-ashpool.freeside/repo.git", nil, [:plaintext]) }
+
+      expect { subject.call("https://tessier-ashpool.freeside/repo.git", nil, [:plaintext]) }.to raise_error(R10K::Git::GitError, /authentication failed/i)
+    end
   end
 end