(RK-243) Refuse to generate rugged credentials more than 50 times. #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's unclear to me if there are situations where the credentials callback instance's #call would be legitimately called more than once in normal r10k operations. |
The new behavior as of libgit2/rugged 0.24.0 is to continue to call the credentials callback until either it raises an error or the server gives up. Since neither was happening for HTTP sources, invalid credentials were leading to an infinite retry loop. SSH sources already seemed to have a client side abort at around 50 attempts.
scotje
force-pushed
the
243_authentication_loop
branch
from
5d67cd2
to
00e5fa8
Compare
scotje
changed the title
|
Bumped the limit up to 50 to be roughly consistent with how many times SSH auth will retry. |
|
👍 I'm happy with this. Tested by hand and watched the infinite loop and the 50 count. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In libgit2/rugged 0.24.0 the callback for fixed credentials continues to be called until either it raises an error or the server gives up. Since neither was happening, invalid credentials were leading to an
infinite retry loop.