Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Important] Fix default-storage-engine default value #171

Merged
merged 2 commits into from
Apr 28, 2013
Merged

[Important] Fix default-storage-engine default value #171

merged 2 commits into from
Apr 28, 2013

Commits on Apr 25, 2013

  1. Fix default-storage-engine default value 

    Without this commit, puppetlabs-mysql breaks mysql configuration by inserting a
dummy default-storage-engine directive. This will prevent mysql daemon from
starting up.

For example:

notice: /Stage[main]/Mysql::Config/File[/etc/mysql/my.cnf]/content:
--- /etc/mysql/my.cnf   2013-04-25 21:36:25.000000000 +0000
+++ /tmp/puppet-file20130425-12937-10tcf50-0    2013-04-25 21:42:49.000000000 +0000
@@ -29,6 +29,8 @@
 expire_logs_days   = 10
 max_binlog_size    = 100M

+default-storage-engine = undef
+

 [mysqldump]
    @ctrlaltdel
    ctrlaltdel committed Apr 25, 2013
    Configuration menu
    Copy the full SHA
    391abe7 View commit details
    Browse the repository at this point in the history

  2. Test to avoid broken default-storage-engine settings

    @ctrlaltdel
    ctrlaltdel committed Apr 25, 2013
    Configuration menu
    Copy the full SHA
    a555848 View commit details
    Browse the repository at this point in the history