[Important] Fix default-storage-engine default value #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this commit, puppetlabs-mysql breaks mysql configuration by inserting a dummy default-storage-engine directive. This will prevent mysql daemon from starting up. For example: notice: /Stage[main]/Mysql::Config/File[/etc/mysql/my.cnf]/content: --- /etc/mysql/my.cnf 2013-04-25 21:36:25.000000000 +0000 +++ /tmp/puppet-file20130425-12937-10tcf50-0 2013-04-25 21:42:49.000000000 +0000 @@ -29,6 +29,8 @@ expire_logs_days = 10 max_binlog_size = 100M +default-storage-engine = undef + [mysqldump]
|
👍 for merge. This just cost me an hour... |
|
agreed. this entry was causing mysql to fail silently. |
|
I just ran into this and wrote my own patch. Guess I should have checked github :) |
bodepd
added a commit
that referenced
this pull request
Apr 28, 2013
[Important] Fix default-storage-engine default value
pmcmaw
pushed a commit
to pmcmaw/puppetlabs-mysql
that referenced
this pull request
Mar 3, 2021
pdksync - Update gha templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, puppetlabs-mysql breaks mysql configuration by inserting a
dummy default-storage-engine directive. This will prevent mysql daemon from
starting up.
For example:
notice: /Stage[main]/Mysql::Config/File[/etc/mysql/my.cnf]/content:
--- /etc/mysql/my.cnf 2013-04-25 21:36:25.000000000 +0000
+++ /tmp/puppet-file20130425-12937-10tcf50-0 2013-04-25 21:42:49.000000000 +0000
@@ -29,6 +29,8 @@
expire_logs_days = 10
max_binlog_size = 100M
+default-storage-engine = undef
+
[mysqldump]