(GH-2900) Log messages from out::message and out::verbose
#2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artlawson
reviewed
Jul 14, 2021
lucywyman
reviewed
Jul 15, 2021
lucywyman
suggested changes
Jul 15, 2021
There was a problem hiding this comment.
We should probably mention this functionality in the debugging section of Writing Plans, but more importantly we explicitly say we don't log out::message here 😅
beechtom
force-pushed
the
2900/log-messages
branch
from
86d9999
to
5709687
Compare
beechtom
force-pushed
the
2900/log-messages
branch
3 times, most recently
from
af81764
to
81cb590
Compare
lucywyman
reviewed
Jul 20, 2021
lucywyman
approved these changes
Jul 20, 2021
This updates the `out::message` plan function to log messages at the `info` level and the `out::verbose` plan function to log messages at the `debug` level. Both functions continue to print to the console as before. !feature * **Log messages from `out::message` and `out::verbose`** ([puppetlabs#2900](puppetlabs#2900)) The `out::message` plan function now logs messages at the `info` level and the `out::verbose` plan function now logs messages at the `debug` level. Both functions continue to print messages to the console.
beechtom
force-pushed
the
2900/log-messages
branch
from
81cb590
to
e56326c
Compare
lucywyman
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
out::messageplan function to log messages at theinfolevel and theout::verboseplan function to log messages at thedebuglevel. Both functions continue to print to the console asbefore.
!feature
Log messages from
out::messageandout::verbose(#2900)
The
out::messageplan function now logs messages at theinfoleveland the
out::verboseplan function now logs messages at thedebuglevel. Both functions continue to print messages to the console.