Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send out::message and out::verbose messages to logs #2900

Closed
lucywyman opened this issue Jun 23, 2021 · 0 comments · Fixed by #2929
Closed

Send out::message and out::verbose messages to logs #2900

lucywyman opened this issue Jun 23, 2021 · 0 comments · Fixed by #2929
Assignees
@beechtom
Labels
Feature New features and improvements.

Comments

@lucywyman
Copy link
Contributor

Use Case

We should add messages printed with out::message and out::verbose plan functions to the logs, since users already have to parse logs and having these messages may be helpful or can be ignored. out::message should be logged at info log level and verbose should be logged at debug level. This should happen after we add the log module.
@lucywyman lucywyman added the Feature New features and improvements. label Jun 23, 2021
@beechtom beechtom self-assigned this Jul 13, 2021
beechtom added a commit to beechtom/bolt that referenced this issue Jul 14, 2021
@beechtom
(puppetlabsGH-2900) Log messages from out::message and out::verbose
86d9999 
This updates the `out::message` plan function to log messages at the
`info` level and the `out::verbose` plan function to log messages at the
`debug` level. Both functions continue to print to the console as
before.

!feature

* **Log messages from `out::message` and `out::verbose`**
  ([puppetlabs#2900](puppetlabs#2900))

  The `out::message` plan function now logs messages at the `info` level
  and the `out::verbose` plan function now logs messages at the `debug`
  level. Both functions continue to print messages to the console.
@beechtom beechtom mentioned this issue Jul 14, 2021
Merged
@beechtom beechtom linked a pull request Jul 14, 2021 that will close this issue
(GH-2900) Log messages from out::message and out::verbose #2929
Merged
beechtom added a commit to beechtom/bolt that referenced this issue Jul 15, 2021
@beechtom
(puppetlabsGH-2900) Log messages from out::message and out::verbose
5709687 
This updates the `out::message` plan function to log messages at the
`info` level and the `out::verbose` plan function to log messages at the
`debug` level. Both functions continue to print to the console as
before.

!feature

* **Log messages from `out::message` and `out::verbose`**
  ([puppetlabs#2900](puppetlabs#2900))

  The `out::message` plan function now logs messages at the `info` level
  and the `out::verbose` plan function now logs messages at the `debug`
  level. Both functions continue to print messages to the console.
beechtom added a commit to beechtom/bolt that referenced this issue Jul 15, 2021
@beechtom
(puppetlabsGH-2900) Log messages from out::message and out::verbose
e3e4724 
This updates the `out::message` plan function to log messages at the
`info` level and the `out::verbose` plan function to log messages at the
`debug` level. Both functions continue to print to the console as
before.

!feature

* **Log messages from `out::message` and `out::verbose`**
  ([puppetlabs#2900](puppetlabs#2900))

  The `out::message` plan function now logs messages at the `info` level
  and the `out::verbose` plan function now logs messages at the `debug`
  level. Both functions continue to print messages to the console.
beechtom added a commit to beechtom/bolt that referenced this issue Jul 15, 2021
@beechtom
(puppetlabsGH-2900) Log messages from out::message and out::verbose
af81764 
This updates the `out::message` plan function to log messages at the
`info` level and the `out::verbose` plan function to log messages at the
`debug` level. Both functions continue to print to the console as
before.

!feature

* **Log messages from `out::message` and `out::verbose`**
  ([puppetlabs#2900](puppetlabs#2900))

  The `out::message` plan function now logs messages at the `info` level
  and the `out::verbose` plan function now logs messages at the `debug`
  level. Both functions continue to print messages to the console.
lucywyman added a commit to lucywyman/bolt that referenced this issue Jul 19, 2021
@lucywyman
(puppetlabsGH-2900) Don't print messages twice
97c9c37 
This adds new functions to the Bolt Logger library to determine the most
verbose (or lowest) log level that will be logged to the console, and
avoid double-printing messages from the `out` module if they will
already be printed by the Logger outputter.
beechtom added a commit to beechtom/bolt that referenced this issue Jul 19, 2021
@beechtom
(puppetlabsGH-2900) Log messages from out::message and out::verbose
81cb590 
This updates the `out::message` plan function to log messages at the
`info` level and the `out::verbose` plan function to log messages at the
`debug` level. Both functions continue to print to the console as
before.

!feature

* **Log messages from `out::message` and `out::verbose`**
  ([puppetlabs#2900](puppetlabs#2900))

  The `out::message` plan function now logs messages at the `info` level
  and the `out::verbose` plan function now logs messages at the `debug`
  level. Both functions continue to print messages to the console.
beechtom added a commit to beechtom/bolt that referenced this issue Jul 20, 2021
@beechtom
(puppetlabsGH-2900) Log messages from out::message and out::verbose
e56326c 
This updates the `out::message` plan function to log messages at the
`info` level and the `out::verbose` plan function to log messages at the
`debug` level. Both functions continue to print to the console as
before.

!feature

* **Log messages from `out::message` and `out::verbose`**
  ([puppetlabs#2900](puppetlabs#2900))

  The `out::message` plan function now logs messages at the `info` level
  and the `out::verbose` plan function now logs messages at the `debug`
  level. Both functions continue to print messages to the console.
lucywyman added a commit that referenced this issue Jul 20, 2021
@lucywyman
Merge pull request #2929 from beechtom/2900/log-messages
a83f07f 
(GH-2900) Log messages from `out::message` and `out::verbose`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beechtom beechtom

Labels
Feature New features and improvements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(GH-2900) Log messages from out::message and out::verbose beechtom/bolt
2 participants
@lucywyman @beechtom