Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default consensus.timeout_commit to 1500ms. #1600

Merged
merged 7 commits into from
Jun 21, 2023
Merged

Change the default consensus.timeout_commit to 1500ms. #1600

merged 7 commits into from
Jun 21, 2023

Commits on Jun 21, 2023

  1. Change the DefaultConsensusTimeoutCommit to 1500ms.

    @SpicyLemon
    SpicyLemon committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    68b1345 View commit details
    Browse the repository at this point in the history

  2. Update the pre-upgrade command to change all consensus.timeout_commit… 

    … settings to 1500ms.
    @SpicyLemon
    SpicyLemon committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    0f3677e View commit details
    Browse the repository at this point in the history

  3. Update the log warning about the consensus.timeout_commit value.

    @SpicyLemon
    SpicyLemon committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    41eaba3 View commit details
    Browse the repository at this point in the history

  4. Add changelog entry.

    @SpicyLemon
    SpicyLemon committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    4ee4916 View commit details
    Browse the repository at this point in the history

  5. Fix some broken unit tests.

    @SpicyLemon
    SpicyLemon committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    bb51d6e View commit details
    Browse the repository at this point in the history

  6. Make those tests I just fixed more robust. They now just use the prov… 

    …config.DefaultConsensusTimeoutCommit value instead of a hard-coded value.
    @SpicyLemon
    SpicyLemon committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    865e4cb View commit details
    Browse the repository at this point in the history

  7. Add some unit tests on the config warner.

    @SpicyLemon
    SpicyLemon committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    3eb9044 View commit details
    Browse the repository at this point in the history