Change the default consensus.timeout_commit to 1500ms. #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…config.DefaultConsensusTimeoutCommit value instead of a hard-coded value.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
==========================================
+ Coverage 63.55% 63.58% +0.03%
==========================================
Files 223 223
Lines 28362 28372 +10
==========================================
+ Hits 18026 18041 +15
+ Misses 9149 9144 -5
Partials 1187 1187
|
nullpointer0x00
approved these changes
Jun 21, 2023
SpicyLemon
added a commit
that referenced
this pull request
Jun 21, 2023
* Change the DefaultConsensusTimeoutCommit to 1500ms. * Update the pre-upgrade command to change all consensus.timeout_commit settings to 1500ms. * Update the log warning about the consensus.timeout_commit value. * Add changelog entry. * Fix some broken unit tests. * Make those tests I just fixed more robust. They now just use the provconfig.DefaultConsensusTimeoutCommit value instead of a hard-coded value. * Add some unit tests on the config warner.
8 tasks
SpicyLemon
added a commit
that referenced
this pull request
Jun 21, 2023
* Change the DefaultConsensusTimeoutCommit to 1500ms. * Update the pre-upgrade command to change all consensus.timeout_commit settings to 1500ms. * Update the log warning about the consensus.timeout_commit value. * Add changelog entry. * Fix some broken unit tests. * Make those tests I just fixed more robust. They now just use the provconfig.DefaultConsensusTimeoutCommit value instead of a hard-coded value. * Add some unit tests on the config warner.
|
This was related to #1569 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
consensus.timeout_committo1500ms.pre-upgradecommand always update theconsensus.timeout_committo1500ms.consensus.timeout_commitlog warning to only log about values being too large (more than3500ms).Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes