Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added call fireEvent when link was removed #918

Conversation

ToTheHit
Copy link
Contributor

Checklist

  • The code has been run through pretty yarn run pretty
  • The tests pass on CircleCI
  • You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • The PR Template has been filled out (see below)
  • Had a beer/coffee because you are awesome

What?

After merge this (#914) PR into Master, I got problem with detect count of links for ports. Before it I used listener linksUpdated and each link had fields sourcePort and targetPort, but now are no there.

How?

Links already have method fireEvent and I just used it :)

Feel good image:

image

@ToTheHit ToTheHit closed this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant