Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct bug of not deleted link #914

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Correct bug of not deleted link #914

merged 3 commits into from
Feb 7, 2022

Conversation

DaSilvaRemi
Copy link
Contributor

@DaSilvaRemi DaSilvaRemi commented Dec 21, 2021

I correct the BUG of the Link doesn't delete when it's not connected to a target port related on issue #895

Checklist

  • The code has been run through pretty yarn run pretty
  • The tests pass on CircleCI
  • You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • The PR Template has been filled out (see below)
  • Had a beer/coffee because you are awesome

What?

Correct the bug linkModel.ts because link doesn't delete when you delete a link by it point.

Why?

because the link doesn't delete

How?

delete the property to avoir NULL value

Feel good image:

image

I correct the BUG of the Link doesn't delete when it's not connected to a target port  related on issue #895
@DaSilvaRemi
Copy link
Contributor Author

Pls accept my pull request

@DaSilvaRemi
Copy link
Contributor Author

@dylanvorster

@dylanvorster dylanvorster merged commit 9b5b14d into projectstorm:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants