refactor(artifact): remove oci artifact support #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we also have specific logic for this mediatype in sync: |
laurentiuNiculae
force-pushed
the
remove-artifact-manifest
branch
3 times, most recently
from
8fed5b1
to
0ebd490
Compare
|
https://github.com/regclient/regclient |
laurentiuNiculae
force-pushed
the
remove-artifact-manifest
branch
2 times, most recently
from
aeee3be
to
6a79f82
Compare
|
If filtering is requested and applied, the response MUST include a header OCI-Filters-Applied: artifactType denoting that an artifactType filter was applied. If multiple filters are applied, the header MUST contain a comma separated list of applied filters. |
laurentiuNiculae
force-pushed
the
remove-artifact-manifest
branch
9 times, most recently
from
f321ccb
to
d133fee
Compare
Codecov Report
@@ Coverage Diff @@
## main #1359 +/- ##
==========================================
+ Coverage 90.70% 90.74% +0.04%
==========================================
Files 99 99
Lines 22390 22032 -358
==========================================
- Hits 20308 19994 -314
+ Misses 1556 1520 -36
+ Partials 526 518 -8
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
laurentiuNiculae
force-pushed
the
remove-artifact-manifest
branch
8 times, most recently
from
ba8b4c9
to
779e8a5
Compare
laurentiuNiculae
requested a review
from eusebiu-constantin-petu-dbk
as a code owner
laurentiuNiculae
requested review from
shimish2,
rchincha and
andaaron
as code owners
laurentiuNiculae
force-pushed
the
remove-artifact-manifest
branch
4 times, most recently
from
9e7f426
to
1d85ee2
Compare
laurentiuNiculae
force-pushed
the
remove-artifact-manifest
branch
4 times, most recently
from
0d1fb43
to
5efa642
Compare
andaaron
reviewed
May 2, 2023
laurentiuNiculae
force-pushed
the
remove-artifact-manifest
branch
from
60a375a
to
3bb2247
Compare
andaaron
previously approved these changes
May 3, 2023
|
Results for some tests I did using latest regctl version: link |
laurentiuNiculae
force-pushed
the
remove-artifact-manifest
branch
from
3bb2247
to
1755182
Compare
- add header to referrers call to indicated applied artifact type filters Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
laurentiuNiculae
force-pushed
the
remove-artifact-manifest
branch
from
1755182
to
acaa066
Compare
andaaron
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
Closes #1425
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.