Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: print flexible nowdoc #1291

Merged
merged 1 commit into from
Mar 31, 2020
Merged

feat: print flexible nowdoc #1291

merged 1 commit into from
Mar 31, 2020

Conversation

czosel
Copy link
Collaborator

@czosel czosel commented Jan 11, 2020 •
edited
Loading

Fixes #1292
Fixed #854

Turns out to be quite tricky to implement the rule suggested in #1274 (comment) - this is a simpler version.

@czosel czosel requested a review from loilo January 11, 2020 00:08
czosel
czosel commented Jan 11, 2020
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
@czosel czosel force-pushed the fix-flexible-nowdoc branch 2 times, most recently from b6d3483 to 9091d6c Compare January 11, 2020 11:03
@czosel
Copy link
Collaborator Author

czosel commented Jan 11, 2020

I took another look, and unfortunately couldn't figure out how to determine if the parent group breaks and indent accordingly. I removed the indentation for now, since this is already an improvement over the current printing.

@evilebottnawi Do you have an idea how to implement this? #1274 (comment)

@czosel
Copy link
Collaborator Author

czosel commented Jan 11, 2020

Tests are failing because of #1292

@czosel czosel force-pushed the fix-flexible-nowdoc branch 3 times, most recently from fa78007 to e9de64c Compare March 14, 2020 18:34
@czosel
Copy link
Collaborator Author

czosel commented Mar 14, 2020

Tests are passing, i'll update the PR once glayzzle/php-parser#509 has landed 🚀

@czosel czosel mentioned this pull request Mar 16, 2020
Merged
@czosel czosel changed the title WIP: print flexible nowdoc feat: print flexible nowdoc Mar 28, 2020
@czosel
Copy link
Collaborator Author

czosel commented Mar 28, 2020 •
edited
Loading

The parser bug has been fixed! I think we have everything ready for our 0.14.0 release featuring support for prettier 2.0 and for PHP 7.3 and 7.4! Would be awesome if someone could have a look at the open merge requests (this one, #1290, #1295) 🙃

@evilebottnawi @loilo

@czosel czosel mentioned this pull request Mar 30, 2020
Closed
9 tasks
alexander-akait
alexander-akait approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@czosel czosel merged commit 8a7c2ed into prettier:master Mar 31, 2020
@czosel czosel deleted the fix-flexible-nowdoc branch March 31, 2020 10:46
@karptonite karptonite mentioned this pull request Aug 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@loilo loilo Awaiting requested review from loilo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nowdoc: invalid trailing comma Support php7.3 and php7.4
3 participants
@czosel @loilo @alexander-akait