Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't skip blank lines in flexible nowdoc #509

Closed
wants to merge 1 commit into from
Closed

fix: don't skip blank lines in flexible nowdoc #509

wants to merge 1 commit into from

Conversation

czosel
Copy link
Collaborator

@czosel czosel commented Mar 14, 2020 •
edited
Loading

Fixes #508

@czosel czosel requested a review from ichiriac March 14, 2020 18:28
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 96.174% when pulling 3770605 on czosel:fix-nowdoc-blank-line-skip into 2db6127 on glayzzle:master.

@czosel czosel mentioned this pull request Mar 14, 2020
Merged
@czosel
Copy link
Collaborator Author

czosel commented Mar 15, 2020

Just noticed #506, which might make this change obsolete.

@ichiriac ichiriac assigned ichiriac and czosel and unassigned ichiriac Mar 26, 2020
@ichiriac
Copy link
Member

Hi @czosel, not sure it's fixed as the code you try to fix is still the same (https://github.com/glayzzle/php-parser/blob/master/src/lexer/strings.js#L243) - can you try again your tests over the master - I've merged the PR

@czosel
Copy link
Collaborator Author

czosel commented Mar 26, 2020

Alright, I'll try to take a look later today! Thanks for looking into this 🙂

@ichiriac ichiriac mentioned this pull request Mar 26, 2020
Closed
@czosel czosel closed this Mar 26, 2020
@czosel czosel deleted the fix-nowdoc-blank-line-skip branch March 28, 2020 17:31
@czosel
Copy link
Collaborator Author

czosel commented Mar 28, 2020 •
edited
Loading

I just updated the prettier plugin to v3.0.0 of the parser, all the tests are passing! 🎉 Thank you for the awesome work on this, and congratulations for reaching this milestone! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichiriac ichiriac Awaiting requested review from ichiriac

Assignees

@czosel czosel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't parse multiple flexible nowdoc blocks with different indentation
3 participants
@czosel @coveralls @ichiriac