Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Replace presto-router/README.txt with README.md #23787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

steveburnett
Copy link
Contributor

@steveburnett steveburnett commented Oct 8, 2024

Description

The file was already formatted as a Markdown file, so conversion was simple.

Motivation and Context

Change suggested by @ethanyzhang.

Impact

None.

Test Plan

Created a README.md in a sandbox GitHub repository with the content of presto-router/README.txt to check the formatting as it is displayed in GitHub. Deleted the test file afterward.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@steveburnett steveburnett self-assigned this Oct 8, 2024
@steveburnett steveburnett requested a review from a team as a code owner October 8, 2024 15:19
@steveburnett
Copy link
Contributor Author

@ethanyzhang and @tdcmeehan, I opened this duplicate PR because the tests were failing on the original #23738. Please review when you have time.

@tdcmeehan
Copy link
Contributor

Should we delete the old router textfile?

tdcmeehan
tdcmeehan previously approved these changes Oct 8, 2024
@steveburnett
Copy link
Contributor Author

Should we delete the old router textfile?

Done, thanks! But now, tests are failing.

@tdcmeehan
Copy link
Contributor

@steveburnett it looks like a relevant failure:

Error:  Failed to execute goal org.apache.maven.plugins:maven-install-plugin:2.5.2:install (default-install) on project presto-router: Failed to install artifact com.facebook.presto:presto-router:txt:readme:0.290-SNAPSHOT: /home/runner/work/presto/presto/presto-router/README.txt (No such file or directory) -> [Help 1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants