Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Replace presto-router/README.txt with README.md #23738

Closed

Conversation

steveburnett
Copy link
Contributor

@steveburnett steveburnett commented Sep 27, 2024

Description

The file was already formatted as a Markdown file, so conversion was simple.

Motivation and Context

Change suggested by @ethanyzhang.

Impact

None.

Test Plan

Created a README.md in a sandbox GitHub repository with the content of presto-router/README.txt to check the formatting as it is displayed in GitHub. Deleted the test file afterward.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

ethanyzhang
ethanyzhang previously approved these changes Sep 27, 2024
tdcmeehan
tdcmeehan previously approved these changes Sep 27, 2024
@steveburnett
Copy link
Contributor Author

steveburnett commented Oct 1, 2024

Made a small change and pushed to re-run the failing tests in case they were intermittently flaky, but they are still failing.

@steveburnett
Copy link
Contributor Author

Closing in favor of #23787.

@steveburnett steveburnett deleted the steveburnett-router-readme branch October 8, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants