[native] Setup-centos.sh simplification and defragmentation. #19064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup-centos.sh variables adjustment to make them not override is user have already set compiler values.
|
This also need to be tested by sb other than me on my developer machine. |
`Setup-centos.sh` script simplification and defragmentation.
From functional point of view nothing changes at all, but from practical point of view:
Using default value notation `VARIABLE=${VARIABLE:-DEFAULT}` instead of overwrite variable `VARIABLE=$DEFAULT` all bellow parameters can be easily overwritten by developer but if nothing is done the right-side default value is sed:
```bash
export FB_OS_VERSION="${FB_OS_VERSION:-'v2022.11.14.00'}"
export nproc="${nproc:-"$(getconf _NPROCESSORS_ONLN)"}"
export CC="${CC:-/opt/rh/gcc-toolset-9/root/bin/gcc}"
export CXX="${CXX:-/opt/rh/gcc-toolset-9/root/bin/g++}"
export CPU_TARGET="${CPU_TARGET:-avx}"
export COMPILER_FLAGS="${COMPILER_FLAGS:-"$(echo -n $(get_cxx_flags $CPU_TARGET))"}"
```
This should be preferred in generic repositories as single change in workflow not always require any changes in the point of interest scripts as they are flexible.
Added `git`, `wget` and `tar` as those may not be yet installed inside the container as we are planning to change the Docker workflow
```
== NO RELEASE NOTE ==
```
Mionsz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup-centos.shscript simplification and defragmentation.From functional point of view nothing changes at all, but from practical point of view:
Using default value notation
VARIABLE=${VARIABLE:-DEFAULT}instead of overwrite variableVARIABLE=$DEFAULTall bellow parameters can be easily overwritten by developer but if nothing is done the right-side default value is sed:This should be preferred in generic repositories as single change in workflow not always require any changes in the point of interest scripts as they are flexible.
Added
git,wgetandtaras those may not be yet installed inside the container as we are planning to change the Docker workflowThis is a connected issue as PR makes the automation scripts more flexible:
#19066
This PR optimizes:
#19211