Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Update native worker docker image creation for CI #19211

Open
wanglinsong opened this issue Mar 17, 2023 · 3 comments
Open

[native] Update native worker docker image creation for CI #19211

wanglinsong opened this issue Mar 17, 2023 · 3 comments
Labels
build prestissimo Presto Native Execution

Comments

@wanglinsong
Copy link
Member

The current docker image creation needs to clone the repository, and is meant to run Dockerfile standalone. This is not the typical use case when the Dockerfile is checked into the repository itself, and not CI friendly.

I had a discussion with @Mionsz and @dnskr, here is the recap.

Ideally, we need 3 Dockerfiles for the native worker image.
1. the build image, which installs all dev packages needed to build Prestissimo source code
2. the runtime base image, which installs runtime dependencies
3. the runtime image, which is the base image + Prestissimo binary and related scripts
And, we will use CentOS Stream8 as the base for all of the above. The runtime image Dockerfile will be located directly inside presto-native-execution folder, along with a build.sh to be called in the CI pipeline. Other 2 images will be built manually.
Milosz is going to update his existing Dockerfile and scripts, with less options, to simplify the build process.
@Mionsz
Copy link
Contributor

Mionsz commented Apr 5, 2023

@wanglinsong @majetideepak The main talk regarding Dockerfile shouldbe moved here. PR with starting point changes have been added. One for main branch and one for Ahana branch:

#19334

PR with slight optimization made to the scripts was added:

#19064

Issue connected - almost the same:

#19066

@elharo
Copy link
Contributor

elharo commented Apr 18, 2024

Is this done now?

@majetideepak
Copy link
Collaborator

Not yet. PR in progress here #21929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build prestissimo Presto Native Execution
Projects
Status: 🆕 Unprioritized
Development

No branches or pull requests

5 participants