api(ui): Drop toggle_ methods. Consolidate update accordion methods. Stronger typing for layout_sidebar(sidebar) and page_sidebar(sidebar)
#788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e a `Sidebar` class as first parameter
…ebar(open: bool)`
…(show=)` and `update_popover(show=)`
…nto `update_accordion_panel(show=)`
schloerke
changed the title
toggle_ methods. Consolidate update accordion methods. Stronger typing for layout_sidebar(sidebar) and page_sidebar(sidebar)
schloerke
added a commit
that referenced
this pull request
Nov 2, 2023
* main: (56 commits) Add actions step for nightly reporting -> Testrail (#774) Remove unused entry in manifest Bump version to 0.6.0.9000 Use latest htmltools Bump version to v0.6.0; Rearrange news to have API changes last Tweaks from testing Fix default width/height with implicit plot output (#792) Update deps (#794) Remove deprecated 'name' parameter from `Outputs` (#791) api(ui): Drop `toggle_` methods. Consolidate update accordion methods. Stronger typing for `layout_sidebar(sidebar)` and `page_sidebar(sidebar)` (#788) bug(sidebar): Revert sidebar icon back to chevron (#789) For `input_action_button`, default to having whitespace around button (#758) Remove output from template app (#775) Add output_args and suspend_display decorators (#786) Update value_box; Update to bootstrap 5.3; Update htmldeps (#772) tests: add sidebar test (#787) Seaborn plots should fill their output_plot (#785) Kwargs to uvicorn run (#780) Add width and height arguments to `@render.plot` (#783) gitgnore dist/ ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #716
Fixes #717
Fixes #730
shiny.uiAPI changeslayout_sidebar(sidebar: Sidebar, *args)page_sidebar(sidebar: Sidebar, *args)toggle_sidebar()->update_sidebar(,show:bool=)is_fillable_container()is_fill_item()toggle_switch()toggle_tooltip()->update_tooltip(,show:bool=)toggle_popover()->update_popover(,show:bool=)accordion_panel_set()->update_accordion(, show:bool | str | list[str] | None)accordion_panel_insert()->insert_accordion_panel()accordion_panel_remove()->remove_accordion_panel()accordion_panel_open()->update_accordion_panel(,show:bool | None)(show=True) orupdate_accordion(,show=True); If they'd like to open a set of panels, they can loop through them and callupdate_accordion_panel()many times.accordion_panel_open()->update_accordion_panel(,show:bool | None)(show=False) orupdate_accordion(,show=False)